Skip to content

[ISSUE #3339]Refactor EventMeshGrpcProducer #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 1 commit into from
Mar 30, 2023
Merged

[ISSUE #3339]Refactor EventMeshGrpcProducer #3340

xwm1992 merged 1 commit into from
Mar 30, 2023

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Mar 5, 2023

Fixes #3339

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Refactor EventMeshGrpcProducer

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@mxsm mxsm mentioned this pull request Mar 5, 2023
Open
2 tasks
@codecov
Copy link

codecov bot commented Mar 5, 2023 •
edited
Loading

Codecov Report

Merging #3340 (40adf00) into master (54cd00f) will decrease coverage by 0.03%.
The diff coverage is 66.34%.

❗ Current head 40adf00 differs from pull request most recent head cb96b92. Consider uploading reports for the commit cb96b92 to get more accurate results

@@             Coverage Diff              @@
##             master    #3340      +/-   ##
============================================
- Coverage     14.62%   14.60%   -0.03%     
- Complexity     1526     1536      +10     
============================================
  Files           651      653       +2     
  Lines         31711    31750      +39     
  Branches       3033     3037       +4     
============================================
- Hits           4638     4637       -1     
- Misses        26657    26684      +27     
- Partials        416      429      +13
Impacted Files Coverage Δ
.../eventmesh/common/enums/EventMeshProtocolType.java 0.00% <0.00%> (ø)
...sh/client/grpc/producer/EventMeshGrpcProducer.java 46.15% <39.13%> (-12.47%) ⬇️
...client/grpc/producer/EventMeshMessageProducer.java 53.33% <53.33%> (ø)
...ventmesh/client/grpc/util/EventMeshClientUtil.java 82.35% <81.19%> (-9.19%) ⬇️
.../org/apache/eventmesh/common/EventMeshMessage.java 35.29% <100.00%> (+3.71%) ⬆️
...sh/client/grpc/consumer/EventMeshGrpcConsumer.java 62.13% <100.00%> (ø)
...tmesh/client/grpc/producer/CloudEventProducer.java 56.71% <100.00%> (+0.65%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit dc6481d into apache:master Mar 30, 2023
@mxsm mxsm deleted the eventmesh-3338 branch April 2, 2023 13:04
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@xwm1992
Merge pull request apache#3340 from mxsm/eventmesh-3338
a5fd58a 
[ISSUE apache#3339]Refactor EventMeshGrpcProducer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement]Refactor EventMeshGrpcProducer

2 participants

@mxsm @xwm1992