Skip to content

[ISSUE #3312]Modify ClientConfiguration class attributes public to private #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mytang0 merged 2 commits into from
Mar 3, 2023
Merged

[ISSUE #3312]Modify ClientConfiguration class attributes public to private #3314

mytang0 merged 2 commits into from
Mar 3, 2023

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Mar 1, 2023

Fixes #3312

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Modify ClientConfiguration class attributes public to private

image

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@xwm1992 xwm1992 changed the title [ISSUE #3312][ISSUE #3312]Modify ClientConfiguration class attributes public to private [ISSUE #3312]Modify ClientConfiguration class attributes public to private Mar 2, 2023
@xwm1992
Copy link
Contributor

xwm1992 commented Mar 2, 2023

@mxsm please take a look of ci test error, maybe due to you change the default value with the @Builder.Default

@mxsm
Copy link
Member Author

mxsm commented Mar 2, 2023 •
edited
Loading

@mxsm please take a look of ci test error, maybe due to you change the default value with the @Builder.Default

@xwm1992 I have noticed the error ,I will fix it, resubmit later

@codecov
Copy link

codecov bot commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #3314 (e205ef2) into master (6636e3a) will decrease coverage by 0.04%.
The diff coverage is 52.94%.

❗ Current head e205ef2 differs from pull request most recent head 3140f37. Consider uploading reports for the commit 3140f37 to get more accurate results

@@             Coverage Diff              @@
##             master    #3314      +/-   ##
============================================
- Coverage     13.09%   13.06%   -0.04%     
- Complexity     1159     1175      +16     
============================================
  Files           550      550              
  Lines         28718    28718              
  Branches       2854     2855       +1     
============================================
- Hits           3761     3752       -9     
- Misses        24632    24641       +9     
  Partials        325      325
Impacted Files Coverage Δ
...entmesh/connector/kafka/consumer/ConsumerImpl.java 0.00% <0.00%> (ø)
.../connector/kafka/consumer/KafkaConsumerRunner.java 0.00% <0.00%> (ø)
...ntmesh/connector/rocketmq/admin/RocketMQAdmin.java 0.00% <0.00%> (ø)
...mesh/connector/rocketmq/admin/command/Command.java 0.00% <0.00%> (ø)
...nector/rocketmq/consumer/RocketMQConsumerImpl.java 8.82% <0.00%> (ø)
...nector/rocketmq/producer/RocketMQProducerImpl.java 8.57% <0.00%> (ø)
...h/registry/nacos/service/NacosRegistryService.java 38.63% <0.00%> (-0.30%) ⬇️
...eventmesh/runtime/connector/ConnectorResource.java 0.00% <0.00%> (ø)
...connector/rocketmq/config/ClientConfiguration.java 85.00% <85.00%> (-15.00%) ⬇️
...connector/rabbitmq/config/ConfigurationHolder.java 90.90% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mytang0
mytang0 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@mytang0 mytang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mytang0 mytang0 merged commit ec19ea2 into apache:master Mar 3, 2023
@mxsm mxsm deleted the eventmesh-3312 branch March 3, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mytang0 mytang0 mytang0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Modify ClientConfiguration class attributes public to private

3 participants

@mxsm @xwm1992 @mytang0