[ISSUE #3307] Kafka Consumer Shuts Down Properly #3308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3308 +/- ##
============================================
- Coverage 13.09% 13.08% -0.02%
Complexity 1159 1159
============================================
Files 550 550
Lines 28718 28710 -8
Branches 2854 2841 -13
============================================
- Hits 3761 3756 -5
+ Misses 24632 24631 -1
+ Partials 325 323 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xwm1992
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3307.
Motivation
It is possible that the Kafka consumer will be closed twice. It will raise an IllegalStateException when being closed again.
Modifications
Since we call
consumer.close()inConsumerImpl.java. The consumer is already closed. In the final shutdown of eventmesh, thefinallysection of code in theKafkaConsumerRunnerwill also be called, resulting in closing the consumer twice.As a result, I modify the code to call the shutdown method in the
KafkaRunner, and then shut down the executor to prevent the executor from running forever.Documentation