Skip to content

[ISSUE #3292]Modify EventMeshHTTPServer class attributes public to private #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 1 commit into from
Mar 15, 2023
Merged

[ISSUE #3292]Modify EventMeshHTTPServer class attributes public to private #3293

xwm1992 merged 1 commit into from
Mar 15, 2023

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Feb 27, 2023

Fixes #3292

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Modify EventMeshHTTPServer class attributes public to private and remove transient keyword

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@mxsm mxsm force-pushed the eventmesh-3292 branch from 89eb06c to dc2b9e4 Compare March 3, 2023 15:20
@codecov
Copy link

codecov bot commented Mar 3, 2023 •
edited
Loading

Codecov Report

Merging #3293 (2a0f6ce) into master (7ec90de) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 2a0f6ce differs from pull request most recent head dc2b9e4. Consider uploading reports for the commit dc2b9e4 to get more accurate results

@@             Coverage Diff              @@
##             master    #3293      +/-   ##
============================================
- Coverage     13.07%   13.05%   -0.03%     
+ Complexity     1195     1192       -3     
============================================
  Files           550      550              
  Lines         28703    28704       +1     
  Branches       2851     2851              
============================================
- Hits           3752     3746       -6     
- Misses        24625    24633       +8     
+ Partials        326      325       -1
Impacted Files Coverage Δ
...he/eventmesh/runtime/boot/EventMeshHTTPServer.java 0.53% <0.00%> (ø)
...l/http/processor/LocalSubscribeEventProcessor.java 0.00% <0.00%> (ø)
.../http/processor/RemoteSubscribeEventProcessor.java 0.00% <0.00%> (ø)
...ttp/processor/RemoteUnSubscribeEventProcessor.java 0.00% <0.00%> (ø)
...re/protocol/http/processor/SubscribeProcessor.java 0.00% <0.00%> (ø)
.../core/protocol/http/push/AsyncHTTPPushRequest.java 0.00% <0.00%> (ø)
...me/core/protocol/http/push/HTTPMessageHandler.java 0.00% <0.00%> (ø)
...ntmesh/runtime/metrics/http/HTTPMetricsServer.java 2.02% <0.00%> (-0.07%) ⬇️
...tandalone/broker/task/HistoryMessageClearTask.java 29.41% <0.00%> (-17.65%) ⬇️
...mesh/connector/standalone/broker/MessageQueue.java 31.64% <0.00%> (-7.60%) ⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mxsm mxsm mentioned this pull request Mar 14, 2023
Closed
@xwm1992 xwm1992 merged commit 5352c59 into apache:master Mar 15, 2023
@mxsm mxsm deleted the eventmesh-3292 branch March 16, 2023 01:11
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@xwm1992
Merge pull request apache#3293 from mxsm/eventmesh-3292
ba21098 
[ISSUE apache#3292]Modify EventMeshHTTPServer class attributes public to private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@Alonexc Alonexc Alonexc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Modify EventMeshHTTPServer class attributes public to private

3 participants

@mxsm @xwm1992 @Alonexc