Skip to content

[ISSUE #3290]Refactor ConsumerManager #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mytang0 merged 1 commit into from
Mar 3, 2023
Merged

[ISSUE #3290]Refactor ConsumerManager #3291

mytang0 merged 1 commit into from
Mar 3, 2023

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Feb 27, 2023

Fixes #3290

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

*Refactor ConsumerManager *

  1. remove useless attributes
  2. optimize code style

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Feb 27, 2023 •
edited
Loading

Codecov Report

Merging #3291 (e30147b) into master (c3c7370) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head e30147b differs from pull request most recent head 2c3d73e. Consider uploading reports for the commit 2c3d73e to get more accurate results

@@             Coverage Diff              @@
##             master    #3291      +/-   ##
============================================
+ Coverage     13.08%   13.09%   +0.01%     
  Complexity     1159     1159              
============================================
  Files           550      550              
  Lines         28721    28715       -6     
  Branches       2853     2851       -2     
============================================
+ Hits           3757     3761       +4     
+ Misses        24638    24629       -9     
+ Partials        326      325       -1
Impacted Files Coverage Δ
...e/core/protocol/http/consumer/ConsumerManager.java 0.00% <0.00%> (ø)
.../apache/eventmesh/common/config/ConfigService.java 44.44% <0.00%> (-0.56%) ⬇️
...otocol/meshmessage/MeshMessageProtocolAdaptor.java 3.77% <0.00%> (-0.08%) ⬇️
...untime/core/protocol/http/push/HTTPClientPool.java 0.00% <0.00%> (ø)
.../trace/pinpoint/exporter/PinpointSpanExporter.java 69.12% <0.00%> (+0.67%) ⬆️
...ventmesh/client/grpc/util/EventMeshClientUtil.java 91.53% <0.00%> (+1.53%) ⬆️
.../admin/handler/QueryRecommendEventMeshHandler.java 92.59% <0.00%> (+3.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mxsm
Copy link
Member Author

mxsm commented Mar 2, 2023

I will rebase this pr and resubmit to trigger execute CI

@mxsm mxsm force-pushed the eventmesh-3290 branch from 0ad0bb7 to 2c3d73e Compare March 2, 2023 14:32
mytang0
mytang0 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@mytang0 mytang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mytang0 mytang0 merged commit 86aa688 into apache:master Mar 3, 2023
@mxsm mxsm deleted the eventmesh-3290 branch March 3, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mytang0 mytang0 mytang0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Refactor ConsumerManager

2 participants

@mxsm @mytang0