Skip to content

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Feb 27, 2023

Fixes #3288

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Refactor ConsumerGroupManager

optimize logic

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #3289 (1a520e0) into master (7ec90de) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 1a520e0 differs from pull request most recent head 1780ef7. Consider uploading reports for the commit 1780ef7 to get more accurate results

@@             Coverage Diff              @@
##             master    #3289      +/-   ##
============================================
- Coverage     13.07%   13.03%   -0.04%     
+ Complexity     1195     1191       -4     
============================================
  Files           550      550              
  Lines         28703    28706       +3     
  Branches       2851     2851              
============================================
- Hits           3752     3743       -9     
- Misses        24625    24638      +13     
+ Partials        326      325       -1     
Impacted Files Coverage Δ
...e/protocol/http/consumer/ConsumerGroupManager.java 0.00% <0.00%> (ø)
...tandalone/broker/task/HistoryMessageClearTask.java 29.41% <0.00%> (-17.65%) ⬇️
...mesh/connector/standalone/broker/MessageQueue.java 31.64% <0.00%> (-7.60%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mxsm mxsm force-pushed the eventmesh-3288 branch from be99e0f to 1780ef7 Compare March 3, 2023 15:18
Copy link
Member

@mytang0 mytang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mytang0 mytang0 merged commit db56052 into apache:master Mar 15, 2023
@mxsm mxsm deleted the eventmesh-3288 branch March 15, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Refactor ConsumerGroupManager

2 participants