Skip to content

Conversation

@epiao55
Copy link
Contributor

@epiao55 epiao55 commented Feb 26, 2023

Fixes #3273.

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@epiao55 epiao55 changed the title [ISSUE apache#3273] fix incorrect validation [ISSUE #3273] fix incorrect validation Feb 26, 2023
@jonyangx
Copy link
Contributor

@epiao55 pls fix the conflicts.

@epiao55
Copy link
Contributor Author

epiao55 commented Feb 27, 2023

@epiao55 pls fix the conflicts.

@jonyangx done.PTAL

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #3274 (0afdfbf) into master (8a014d4) will increase coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 0afdfbf differs from pull request most recent head 8917ab6. Consider uploading reports for the commit 8917ab6 to get more accurate results

@@             Coverage Diff              @@
##             master    #3274      +/-   ##
============================================
+ Coverage     13.08%   13.12%   +0.04%     
- Complexity     1159     1163       +4     
============================================
  Files           550      550              
  Lines         28715    28718       +3     
  Branches       2852     2854       +2     
============================================
+ Hits           3757     3770      +13     
+ Misses        24632    24622      -10     
  Partials        326      326              
Impacted Files Coverage Δ
...ocol/http/processor/BatchSendMessageProcessor.java 0.00% <0.00%> (ø)
.../apache/eventmesh/common/config/ConfigService.java 44.44% <0.00%> (-0.56%) ⬇️
...otocol/meshmessage/MeshMessageProtocolAdaptor.java 3.77% <0.00%> (-0.08%) ⬇️
...untime/core/protocol/http/push/HTTPClientPool.java 0.00% <0.00%> (ø)
.../trace/pinpoint/exporter/PinpointSpanExporter.java 69.12% <0.00%> (+0.67%) ⬆️
...ventmesh/client/grpc/util/EventMeshClientUtil.java 91.53% <0.00%> (+1.53%) ⬆️
.../admin/handler/QueryRecommendEventMeshHandler.java 92.59% <0.00%> (+3.70%) ⬆️
...mesh/connector/standalone/broker/MessageQueue.java 39.24% <0.00%> (+7.59%) ⬆️
...tandalone/broker/task/HistoryMessageClearTask.java 47.05% <0.00%> (+17.64%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit adbe5ee into apache:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect validation may cause the batch send of events to fail

3 participants