Skip to content

[ISSUE #3271]Fix handle http message throw IllegalReferenceCountException #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 1 commit into from
Feb 27, 2023
Merged

[ISSUE #3271]Fix handle http message throw IllegalReferenceCountException #3272

xwm1992 merged 1 commit into from
Feb 27, 2023

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Feb 26, 2023

Fixes #3271

Motivation

if HTTPHandler execute ReferenceCountUtil.release method, then SimpleChannelInboundHandler execute ReferenceCountUtil.release will throw IllegalReferenceCountException. Because relase is performed twice for one reference. So need to remove ReferenceCountUtil.release from HTTPHandler

Modifications

Fix handle http message throw IllegalReferenceCountException

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Feb 26, 2023 •
edited
Loading

Codecov Report

Merging #3272 (856d486) into master (987378d) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 856d486 differs from pull request most recent head 3a36275. Consider uploading reports for the commit 3a36275 to get more accurate results

@@             Coverage Diff              @@
##             master    #3272      +/-   ##
============================================
+ Coverage     13.07%   13.09%   +0.02%     
  Complexity     1159     1159              
============================================
  Files           550      550              
  Lines         28763    28716      -47     
  Branches       2857     2854       -3     
============================================
  Hits           3761     3761              
+ Misses        24677    24630      -47     
  Partials        325      325
Impacted Files Coverage Δ
...che/eventmesh/runtime/boot/AbstractHTTPServer.java 1.12% <0.00%> (ø)
...g/apache/eventmesh/client/http/util/HttpUtils.java 0.00% <0.00%> (ø)
.../eventmesh/spi/loader/JarExtensionClassLoader.java 13.55% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit 3e9b1ee into apache:master Feb 27, 2023
@mxsm mxsm deleted the eventmesh-3271 branch February 27, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Fix handle http message throw IllegalReferenceCountException

2 participants

@mxsm @xwm1992