[ISSUE #3267] Refactor RequestContext #3268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3268 +/- ##
============================================
- Coverage 13.07% 13.04% -0.03%
+ Complexity 1195 1191 -4
============================================
Files 550 550
Lines 28703 28700 -3
Branches 2851 2850 -1
============================================
- Hits 3752 3743 -9
- Misses 24625 24632 +7
+ Partials 326 325 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jonyangx
reviewed
Feb 26, 2023
| throw new TimeoutException("operation timeout, context.key=" + c.getKey()); | ||
| } | ||
| return c.getResponse(); | ||
| return context.getResponse(timeout); |
Contributor
There was a problem hiding this comment.
Where execute supplyAsync with CompletableFuture？
Contributor
There was a problem hiding this comment.
@mxsm I think original code is better ，its advantages include currency and timeout controller logic.
Member
Author
|
@jonyangx PTAL~ |
jonyangx
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3267
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Refactor RequestContext
CountDownLatch replace with CompletableFuture
Documentation