Issue #2971 #3262
Merged
Issue #2971 #3262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alonexc
reviewed
Feb 27, 2023
| final String subRes = HttpUtils.post(httpClient, target, subscribeParam); | ||
| final EventMeshRetObj ret = JsonUtils.parseObject(subRes, EventMeshRetObj.class); | ||
| if (ret.getRetCode() != EventMeshRetCode.SUCCESS.getRetCode()) { | ||
| throw new EventMeshException(ret.getRetCode(), ret.getRetMsg()); |
Contributor
There was a problem hiding this comment.
Sorry, the number of issue description lines may be incorrect due to the code update. The places to be changed here are as follows:
Update EventMeshHttpConsumer.java
Alonexc
reviewed
Feb 28, 2023
| final EventMeshRetObj ret = JsonUtils.parseObject(subRes, EventMeshRetObj.class); | ||
| if (ret.getRetCode() != EventMeshRetCode.SUCCESS.getRetCode()) { | ||
| throw new EventMeshException(ret.getRetCode(), ret.getRetMsg()); | ||
| if (Object.requireNonNull(ret).getRetCode() != EventMeshRetCode.SUCCESS.getRetCode()) { |
Contributor
There was a problem hiding this comment.
Modify: Objects.requireNonNull()
The same is true for other repair points.
Alonexc
reviewed
Feb 28, 2023
| if (ret.getRetCode() != EventMeshRetCode.SUCCESS.getRetCode()) { | ||
| throw new EventMeshException(ret.getRetCode(), ret.getRetMsg()); | ||
| if (Object.requireNonNull(ret).getRetCode() != EventMeshRetCode.SUCCESS.getRetCode()) { | ||
| throw new EventMeshException(ret.getRetCode(),ret.getRetMsg()); |
Contributor
There was a problem hiding this comment.
A space is missing before ret.getRetMsg().
Update EventMeshHttpConsumer.java
Codecov Report
@@ Coverage Diff @@
## master #3262 +/- ##
============================================
+ Coverage 13.07% 13.09% +0.01%
Complexity 1159 1159
============================================
Files 550 550
Lines 28765 28724 -41
Branches 2857 2855 -2
============================================
Hits 3761 3761
+ Misses 24679 24638 -41
Partials 325 325
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.