Skip to content

Issue #3256 #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mytang0 merged 5 commits into from
Mar 3, 2023
Merged

Issue #3256 #3261

mytang0 merged 5 commits into from
Mar 3, 2023

Conversation

@piyush280599
Copy link
Contributor

@piyush280599 piyush280599 commented Feb 24, 2023

No description provided.

@Alonexc
Copy link
Contributor

Alonexc commented Feb 27, 2023

@piyush280599 Missing import:
import java.util.Objects;

@Markliniubility Markliniubility mentioned this pull request Feb 27, 2023
Closed
@Alonexc
Copy link
Contributor

Alonexc commented Feb 28, 2023

image
Please check for style errors. It should be 'import java. util. Objects;' Import sequence error:
image

@codecov
Copy link

codecov bot commented Mar 3, 2023 •
edited
Loading

Codecov Report

Merging #3261 (9382b15) into master (c978891) will increase coverage by 0.01%.
The diff coverage is 21.05%.

❗ Current head 9382b15 differs from pull request most recent head 7ccc6f7. Consider uploading reports for the commit 7ccc6f7 to get more accurate results

@@             Coverage Diff              @@
##             master    #3261      +/-   ##
============================================
+ Coverage     13.07%   13.09%   +0.01%     
  Complexity     1159     1159              
============================================
  Files           550      550              
  Lines         28765    28724      -41     
  Branches       2857     2855       -2     
============================================
  Hits           3761     3761              
+ Misses        24679    24638      -41     
  Partials        325      325
Impacted Files Coverage Δ
...mesh/common/protocol/grpc/protos/BatchMessage.java 0.00% <ø> (ø)
...entmesh/connector/kafka/consumer/ConsumerImpl.java 0.00% <0.00%> (ø)
.../connector/kafka/consumer/KafkaConsumerRunner.java 0.00% <0.00%> (ø)
...h/registry/nacos/service/NacosRegistryService.java 38.63% <0.00%> (-0.30%) ⬇️
...che/eventmesh/runtime/boot/AbstractHTTPServer.java 1.12% <0.00%> (-0.01%) ⬇️
...eventmesh/runtime/connector/ConnectorResource.java 0.00% <0.00%> (ø)
...ocol/http/processor/BatchSendMessageProcessor.java 0.00% <0.00%> (ø)
...ol/http/processor/BatchSendMessageV2Processor.java 0.00% <0.00%> (ø)
...protocol/http/processor/ReplyMessageProcessor.java 0.00% <0.00%> (ø)
...otocol/http/processor/SendAsyncEventProcessor.java 0.00% <0.00%> (ø)
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mytang0
mytang0 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@mytang0 mytang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mytang0 mytang0 merged commit 0bf6235 into apache:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mytang0 mytang0 mytang0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@piyush280599 @Alonexc @mytang0