[ISSUE #295] add licenses of apache for runtime module #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@liangyuanpeng did you add the license headers with license-eye? I think you'd better also add it as GitHub Action to automatically check and review future pull requests, it's a cool feature to ease the reviewers from reviewing the license and the contributors to add license headers, it works like this apache/skywalking#6716 (review) , if you have problem using it, I'm glad to help |
Contributor
Author
|
@kezhenxu94 Yes, I just use container for license-eye now and i will try it from github action. Will consider contributing to eventmesh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed:
fixed #295