[ISSUE #2196] [Workflow] Add prometheus metrics #2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
hi @walterlife, could you help to review this pr? |
walterlife
reviewed
Dec 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #2303 +/- ##
============================================
- Coverage 11.78% 11.77% -0.02%
+ Complexity 903 901 -2
============================================
Files 473 469 -4
Lines 27856 27783 -73
Branches 3000 3000
============================================
- Hits 3284 3272 -12
+ Misses 24276 24216 -60
+ Partials 296 295 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterlife
reviewed
Dec 3, 2022
| MetricsSwitchReject = "reject" | ||
| MetricsSwitchPass = "pass" | ||
|
|
||
| MetricsStartRequest = "start_request" |
Contributor
There was a problem hiding this comment.
Is it possible to initialize the metric collector first?
@horoc
| case gauge: | ||
| return p.histograms[name] | ||
| default: | ||
| panic("prometheus metrics get collector error, illegal collector type") |
Contributor
There was a problem hiding this comment.
try to use error return instead of panic
@horoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2196
Motivation
#2196
Modifications
#2196
Documentation
None