[ISSUE #212]For multiple listening instances, only the last started instance can receive messages #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rted instance can receive messages
iNanos
approved these changes
Feb 7, 2021
| proxyHTTPServer.localClientInfoMapping.put(groupTopicClientMapping.getKey(), groupTopicClientMapping.getValue()); | ||
| }else { | ||
| List<Client> tmpClientList = groupTopicClientMapping.getValue(); | ||
| for (Client tmpClient : tmpClientList){ |
Contributor
There was a problem hiding this comment.
Suggested change
| for (Client tmpClient : tmpClientList){ | |
| for (Client tmpClient : tmpClientList){ | |
| boolean isContains = false; | |
| for (Client localClient : localClientList){ | |
| if (StringUtils.equals(localClient.url, tmpClient.url)){ | |
| isContains = true; | |
| break; | |
| } | |
| } | |
| if (!isContains){ | |
| localClientList.add(tmpClient); | |
| } | |
| } |
These code can be simplified and extracted as a method will be better
Contributor
Author
There was a problem hiding this comment.
ok, I will fix that.
…rted instance can receive messages
xwm1992
added a commit
that referenced
this pull request
Aug 4, 2022
[ISSUE #212]For multiple listening instances, only the last started instance can receive messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix：this problem because of heartBeat processor client info managing error