Skip to content

[Enhancement] Do some code optimization.[consumer.go] #3772

@Alonexc

Description

@Alonexc

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

This issue is a subproject issue of eventmesh. the subproject address is:

https://github.com/apache/eventmesh-go

image
image
located at:
eventmesh-go/plugin/connector/rocketmq/consumer.go line 105,140,173,186,219
analysis and expalanation:
186-221 lines are duplicate of plugin/connector/rocketmq/consumer.go:140-175 (dupl)

Describe the solution you'd like

Ranme _
image

Repeat code extraction as method.
image
image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions