[ISSUE #3466] Save and re-use this "Random" (#3784)

piyush280599 · xwm1992 · web-flow · commit c5b7cf44e526 · 2023-05-04T11:13:47.000+08:00
* [Enhancement] #3466 * Update TcpClient.java * Update TcpClient.java * Update TcpClient.java --------- Co-authored-by: mike_xwm <mike_xwm@126.com>
diff --git a/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/common/TcpClient.java b/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/common/TcpClient.java
@@ -24,10 +24,10 @@
 import org.apache.eventmesh.common.protocol.tcp.UserAgent;
 import org.apache.eventmesh.common.protocol.tcp.codec.Codec;
 
-
 import java.io.Closeable;
 import java.net.InetSocketAddress;
-import java.util.Random;
+import java.security.NoSuchAlgorithmException;
+import java.security.SecureRandom;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ExecutionException;
@@ -60,7 +60,15 @@
 @Slf4j
 public abstract class TcpClient implements Closeable {
 
-    protected static final transient int CLIENTNO = (new Random()).nextInt(1000);
+    protected static transient int CLIENTNO = 0;
+    
+    static {
+        try {
+            CLIENTNO = SecureRandom.getInstanceStrong().nextInt(1000);
+        } catch (NoSuchAlgorithmException e) {
+            log.error("Failed to generate a random number!", e);
+        }
+    }
 
     protected final transient ConcurrentHashMap<Object, RequestContext> contexts = new ConcurrentHashMap<>();
 
