Skip to content

Conversation

@Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Nov 21, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Revert pr #17809 because #17801 is not a bug but not used correctly.

v5.3.3 introduced a new option stackStrategy, and if a series should always stack from 0 rather than other series, it should be set to 'negative' or 'positive'. If not set, the default value is 'samesign' and the data should be stacked on other series no matter the other part of the series is positive or negative.

Fixed issues

PR #17809 makes the test case axis-filter-extent2.html fail and was found before new version release.

Details

Before: What was the problem?

axis-filter-extent2.html fails.

After: How does it behave after the fixing?

axis-filter-extent2.html doesn't fail and developers should set stackStrategy: 'negative' in cases like #17801 or #17942. A working demo is here.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Nov 21, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart merged commit b454ae2 into release Nov 21, 2022
@plainheart plainheart deleted the release-dev branch November 21, 2022 08:14
@echarts-bot
Copy link

echarts-bot bot commented Nov 21, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart restored the release-dev branch November 21, 2022 08:14
@plainheart plainheart deleted the release-dev branch November 21, 2022 08:15
@plainheart plainheart restored the release-dev branch November 21, 2022 08:15
@plainheart plainheart deleted the release-dev branch November 21, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants