Skip to content

Conversation

@YuShengHou
Copy link
Contributor

…7801

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix dataStack error when data is zero

Fixed issues

#17801

Details

Before: What was the problem?

problem

After: How does it behave after the fixing?

zero is neither positive nor negative stack

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 21, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@Ovilia Ovilia merged commit 7f029b4 into apache:master Oct 25, 2022
@echarts-bot
Copy link

echarts-bot bot commented Oct 25, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.4.1 milestone Oct 25, 2022
@YuShengHou YuShengHou deleted the fix-17801 branch October 25, 2022 11:48
@plainheart plainheart changed the title fix(dataStack): zero is neither positive nor negative stack, close #1… fix(stack): show stack value 0 in the starting position Nov 20, 2022
Ovilia added a commit that referenced this pull request Nov 21, 2022
@Ovilia Ovilia mentioned this pull request Nov 21, 2022
8 tasks
plainheart added a commit that referenced this pull request Nov 21, 2022
@plainheart plainheart removed this from the 5.4.1 milestone Nov 21, 2022
@Ovilia
Copy link
Contributor

Ovilia commented Nov 21, 2022

@MainHou Thanks for your contribution and sorry that I misunderstood the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants