fix: When component tooltip.formatter is not specified, use a specific default formatter, rather than use global tooltip.formatter as default. Fix #14939
#14972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ip.formatter, but has component specific default tooltip.formatter.
|
Thanks for your contribution! The pull request is marked to be |
100pah
changed the title
tooltip.formatter is not specified, use a specific default formatter, rather than use global tooltip.formatter as default.tooltip.formatter is not specified, use a specific default formatter, rather than use global tooltip.formatter as default. Fix #14939
pissang
approved these changes
May 18, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: When component
tooltip.formatteris not specified, use a specific default formatter, rather than use globaltooltip.formatteras default.That because the global
tooltip.formatteris usually configured for series. But tooltip formatter usually can not be shared by series and components (they have different params). So the globaltooltip.formatteris usually not applicable for component.This PR make a specific default tooltip formatter for component, which returns the item name.
Since
v5.1.0component tooltip inherits the configs of the global tooltip. So there is no such issue beforev5.1.0.Fix #14939
Brief Information
This pull request is in the type of:
What does this PR do?
test case: test/tooltip-component.html (the last case).