feat(markLine): symbolRotate for markLine accepts an array as the parameter to specify symbol rotation at the two endpoints of the mark line. #12736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to specify symbol rotation at the two ends of the mark line.
3 tasks
|
Sorry for the very late replay, I suddenly saw this PR and it looks perfect! Thanks again!! |
plainheart
added a commit
that referenced
this pull request
Mar 1, 2021
- Resolves #9325 - Resolves #14106 - Resolves #4771 2) feat: `markLine.symbolRotate` can be an array to specify symbol rotation at the two endpoints. - Related #12736, #12392 3) feat: add `markLine.symbolKeepAspect` and fix `symbolKeepAspect` doesn't work bug. 4) feat: `symbolOffset` can be a callback function, close #12495.
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
symbolRotateformarkLineaccepts an array as the parameter to specify symbol rotation at the two ends of the mark line. I think it may be very helpful in some cases.Related issues
symbolRotateformarkLinedoes not work. close #12388. #12392 (comment)Details
Before: What was the problem?
We can not specify different rotations for symbols at the two endpoints of the mark line.
After: How is it fixed in this PR?
By specifying an array like
[fromSymbolRotation, toSymbolRotation]formarkLine.symbolRotate, we can set different rotations for symbols at the two endpoints of the mark lineUsage
Are there any API changes?
Added an option
markLine.symbolRotate, which accepts a number or an array having two numeric elements.Related test cases or examples to use the new APIs
Please reder to
test/markLine-symbolRotate.html.