-
Notifications
You must be signed in to change notification settings - Fork 19.8k
fix(line): fix symbolRotate for markLine does not work. close #12388.
#12392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge some commits from apache/master
Merge some commits from apache/master.
|
Thanks for your contribution! The pull request is marked to be |
symbolRotate for markLine does not work. close #12388.
|
It works perfect for me! Thanks for quick fixing :) |
|
@YiYingWu1302 Could you provide an example? |
|
@plainheart I set markLine: {
symbol: 'triangle'
} |
…pecified or NaN.
|
THX! That's not expected. I've made a fix for it, now it should work well. A default rotation action would be performed if |
|
It works well! markLine: {
symbol: 'triangle',
symbolRotate: [0, 180]
} |
|
@YiYingWu1302 That's OK, but we may have to wait until this PR is merged since current PR is for fixing. After it is merged, you can open a feature request issue for these requirements. BTW, sorry for late reply. :) |
|
@plainheart I get it. Thanks for your kindly reply! |
Hi~ @YiYingWu1302 I've made some commits for this feature you mentioned about two months ago. |
- Resolves #9325 - Resolves #14106 - Resolves #4771 2) feat: `markLine.symbolRotate` can be an array to specify symbol rotation at the two endpoints. - Related #12736, #12392 3) feat: add `markLine.symbolKeepAspect` and fix `symbolKeepAspect` doesn't work bug. 4) feat: `symbolOffset` can be a callback function, close #12495.


Brief Information
This pull request is in the type of:
What does this PR do?
Fix the option
symbolRotateinmarkLinedoes not work for line series. Close #12388.Fixed issues
Related test cases
Refer to
test/markLine-symbolRotate.html