Fix: barBorderRadius didn't work #12331
Conversation
|
Thanks for your contribution! The pull request is marked to be |
src/layout/barGrid.js
Outdated
| width: width, | ||
| height: height | ||
| height: height, | ||
| r: seriesModel.get('barBorderRadius'), |
There was a problem hiding this comment.
I believe this should be itemModel.get('barBorderRadius')?
There was a problem hiding this comment.
@pissang item border radius wasn't set from here. so I have it removed.
| x: layout.x + signX * fixedLineWidth / 2, | ||
| y: layout.y + signY * fixedLineWidth / 2, | ||
| r: layout.rb, | ||
| width: layout.width - signX * fixedLineWidth, |
There was a problem hiding this comment.
This layout is used for bar rect element. r property here will not be used.
| x: isHorizontalOrRadial ? layout.x : coordLayout.x, | ||
| y: isHorizontalOrRadial ? coordLayout.y : layout.y, | ||
| r: isHorizontalOrRadial ? layout.r : coordLayout.r, | ||
| width: isHorizontalOrRadial ? layout.width : coordLayout.width, |
There was a problem hiding this comment.
I think it should be layout.rb here. Also coordLayout is a rect. It don't have r property.
Also, I prefer not to put radius in the layout. See comment below.
| height: height | ||
| height: height, | ||
| rb: seriesModel.get('backgroundStyle.barBorderRadius') | ||
| }); |
There was a problem hiding this comment.
radius is not a layout related property. So I think it's better to set the property here.
bgEl.setShape('r', backgroundModel.get('barBorderRadius'));
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
2 participants
Brief Information
This pull request is in the type of:
What does this PR do?
Fix barBorderRadius didn't work, not only background but also item
Fixed issues
Close #12321
Details
After: How is it fixed in this PR?
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information