Skip to content

image.registry not being respect #1282

@zyue110026

Description

@zyue110026

We have noticed an instance of incorrect helming in one of your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from trivy-operator#729 regarding the incorrect helming defect.

image.registry does not take effect when changed to a value other than default value 'docker.io'. This is due to missing implementation for this value in helm charts deploy.yaml file:

image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.Version }}"

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the REAMDE of this repository and believe that this is not a duplicate.

Environment

  • Dubbo Admin version: main
  • Registry center detail (type and version): xxx
  • Operating System version: xxx
  • Java version: xxx

Steps to reproduce this issue

  1. change the value of image.registry in values.yaml file
  2. using helm chart to deploy

Pls. provide [GitHub address] to reproduce this issue.

Expected Result

change image.registry can take affect, or delete image.registry from values.yaml file

Actual Result

image.registry always be 'docker.io'

If there is an exception, please attach the exception trace:

Just put your stack trace here!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions