Skip to content

Conversation

@zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 19, 2025

What is the purpose of the change?

The download url of Zookeeper 3.8.4 was changed again.

Run wget -t 1 -T 120 https://dlcdn.apache.org/zookeeper/zookeeper-3.8.4/apache-zookeeper-3.8.4-bin.tar.gz
--2025-09-19 06:07:34--  https://dlcdn.apache.org/zookeeper/zookeeper-3.8.4/apache-zookeeper-3.8.4-bin.tar.gz
Resolving dlcdn.apache.org (dlcdn.apache.org)... 151.101.2.132, 2a04:4e42::644
Connecting to dlcdn.apache.org (dlcdn.apache.org)|151.101.2.132|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2025-09-19 06:07:34 ERROR 404: Not Found.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.01%. Comparing base (bc543b6) to head (4b249b9).
⚠️ Report is 16 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15697      +/-   ##
============================================
- Coverage     61.02%   61.01%   -0.02%     
+ Complexity    11704    11696       -8     
============================================
  Files          1923     1923              
  Lines         87078    87078              
  Branches      13113    13113              
============================================
- Hits          53141    53132       -9     
- Misses        28497    28500       +3     
- Partials       5440     5446       +6     
Flag Coverage Δ
integration-tests-java21 32.90% <ø> (+<0.01%) ⬆️
integration-tests-java8 33.00% <ø> (+0.05%) ⬆️
samples-tests-java21 32.63% <ø> (-0.01%) ⬇️
samples-tests-java8 30.34% <ø> (-0.01%) ⬇️
unit-tests-java11 58.98% <ø> (-0.02%) ⬇️
unit-tests-java17 58.76% <ø> (+0.01%) ⬆️
unit-tests-java21 58.75% <ø> (-0.02%) ⬇️
unit-tests-java8 58.99% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw requested review from EarthChen and RainYuY September 19, 2025 10:55
@zrlw zrlw force-pushed the 3.3-fixed-ZKdownloadUrl branch from 6a6be5a to 4b249b9 Compare September 19, 2025 23:58
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RainYuY RainYuY merged commit 8202597 into apache:3.3 Sep 20, 2025
32 checks passed
@zrlw zrlw deleted the 3.3-fixed-ZKdownloadUrl branch September 20, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants