Skip to content

Conversation

@zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 2, 2025

What is the purpose of the change?

Unset DEBIAN_MIRROR which was set in the workflow files.
DEBIAN_MIRROR should not be set in dubbo workflows because the docker image name of dubbo-samples and dubbo-integration-cases was upgraded to bullseye.
Debian changed the archive URL again, we don't know whether current Debian archive URL is temporary or not, so it might be better to upgrade the test docker image version to the lastest - bullseye.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

…dubbo-samples was already upgraded from the old buster to the latest bullseye
@zrlw zrlw requested a review from AlbumenJ September 2, 2025 08:49
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.01%. Comparing base (5b9adb0) to head (2d26ef6).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15667      +/-   ##
============================================
- Coverage     61.06%   61.01%   -0.05%     
+ Complexity    11704    11693      -11     
============================================
  Files          1923     1923              
  Lines         87069    87069              
  Branches      13112    13112              
============================================
- Hits          53165    53125      -40     
- Misses        28465    28491      +26     
- Partials       5439     5453      +14     
Flag Coverage Δ
integration-tests-java21 32.91% <ø> (+0.01%) ⬆️
integration-tests-java8 32.95% <ø> (-0.01%) ⬇️
samples-tests-java21 32.62% <ø> (-0.02%) ⬇️
samples-tests-java8 30.35% <ø> (-0.02%) ⬇️
unit-tests-java11 59.01% <ø> (ø)
unit-tests-java17 58.74% <ø> (-0.02%) ⬇️
unit-tests-java21 58.74% <ø> (-0.03%) ⬇️
unit-tests-java8 59.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw requested a review from oxsean September 2, 2025 09:26
Copy link
Contributor

@oxsean oxsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zrlw
Copy link
Contributor Author

zrlw commented Sep 3, 2025

Current github action will always fail if we do not take any action since Debian changed its archive site address.

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 605836f into apache:3.3 Sep 3, 2025
57 of 63 checks passed
@zrlw zrlw deleted the 3.3-unset-DEBIAN_MIRROR branch September 3, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants