Skip to content

fixed the issue that the file name of message.proto is not supported#15655

Merged
zrlw merged 5 commits intoapache:3.3from
nichanghao:fix/idl_name
Sep 24, 2025
Merged

fixed the issue that the file name of message.proto is not supported#15655
zrlw merged 5 commits intoapache:3.3from
nichanghao:fix/idl_name

Conversation

@nichanghao
Copy link
Copy Markdown
Contributor

@nichanghao nichanghao commented Aug 28, 2025

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.03%. Comparing base (8202597) to head (860668d).

Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #15655      +/-   ##
============================================
+ Coverage     61.02%   61.03%   +0.01%     
- Complexity    11703    11706       +3     
============================================
  Files          1923     1923              
  Lines         87078    87078              
  Branches      13113    13113              
============================================
+ Hits          53139    53148       +9     
+ Misses        28499    28487      -12     
- Partials       5440     5443       +3
Flag Coverage Δ
integration-tests-java21 32.91% <ø> (+<0.01%) ⬆️
integration-tests-java8 33.00% <ø> (-0.01%) ⬇️
samples-tests-java21 32.71% <ø> (+0.07%) ⬆️
samples-tests-java8 30.36% <ø> (+0.09%) ⬆️
unit-tests-java11 59.00% <ø> (-0.01%) ⬇️
unit-tests-java17 58.75% <ø> (+0.01%) ⬆️
unit-tests-java21 58.75% <ø> (+0.01%) ⬆️
unit-tests-java8 58.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nichanghao
Copy link
Copy Markdown
Contributor Author

nichanghao commented Aug 28, 2025

It seems there might be an issue with the action, but I can't see the specific reason.

@zrlw
Copy link
Copy Markdown
Contributor

zrlw commented Aug 29, 2025

3c124536-e61a-4dc5-98e7-da138d4fef30

@nichanghao
Copy link
Copy Markdown
Contributor Author

nichanghao commented Aug 29, 2025 

04:12:23.682 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_rt_milliseconds_p99 don't exists
04:12:23.685 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_rt_milliseconds_p90 don't exists
04:12:23.685 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_rt_max_milliseconds_aggregate don't exists
04:12:23.685 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_requests_business_failed_aggregate don't exists
04:12:23.686 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_requests_failed_service_unavailable_total_aggregate don't exists
04:12:23.687 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_requests_limit_aggregate don't exists
04:12:23.691 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_qps_total don't exists
04:12:23.691 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_rt_milliseconds_p50 don't exists
04:12:23.692 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_rt_milliseconds_p95 don't exists
04:12:23.692 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_requests_failed_aggregate don't exists
04:12:23.692 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_rt_avg_milliseconds_aggregate don't exists
04:12:23.692 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_requests_failed_total_aggregate don't exists
04:12:23.692 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_requests_failed_network_total_aggregate don't exists
04:12:23.693 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_rt_min_milliseconds_aggregate don't exists
04:12:23.693 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_requests_failed_codec_total_aggregate don't exists
04:12:23.699 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_provider_requests_timeout_failed_aggregate don't exists
04:12:23.699 |-ERROR [main] cs.prometheus.consumer.ConsumerMetricsIT:143 -| metric key:dubbo_consumer_requests_failed_service_unavailable_total don't exists
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 11.661 s <<< FAILURE! - in org.apache.dubbo.samples.metrics.prometheus.consumer.ConsumerMetricsIT
test(org.apache.dubbo.samples.metrics.prometheus.consumer.ConsumerMetricsIT)  Time elapsed: 11.486 s  <<< FAILURE!
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.apache.dubbo.samples.metrics.prometheus.consumer.ConsumerMetricsIT.test(ConsumerMetricsIT.java:145)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray2(ReflectionUtils.java:206)
	at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:161)
	at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:84)
	at org.apache.dubbo.test.runner.ClassloaderSurefireStarter.runSuitesInProcess(ClassloaderSurefireStarter.java:78)
	at org.apache.dubbo.test.runner.TestRunnerMain.runInJunit4(TestRunnerMain.java:233)
	at org.apache.dubbo.test.runner.TestRunnerMain.main(TestRunnerMain.java:156)


Results:

Failures: 
  ConsumerMetricsIT.test:145

Tests run: 1, Failures: 1, Errors: 0, Skipped: 0

I don't understand why my changes would affect this part, I tested ConsumerMetricsIT locally and it's ok

@zrlw
Copy link
Copy Markdown
Contributor

zrlw commented Aug 30, 2025

I don't understand why my changes would affect this part, I tested ConsumerMetricsIT locally and it's ok

it's not your fault, it seemed that dubbo-samples-metrics-prometheus need to be fixed as its consumer doesn't generate metrics data as soon as possible.

@zrlw
Copy link
Copy Markdown
Contributor

zrlw commented Aug 30, 2025

you'd better add a unit test case to ensure this PR has fixed the issue #15410

@zrlw zrlw added the type/enhancement Everything related with code enhancement or performance label Aug 30, 2025
@nichanghao
Copy link
Copy Markdown
Contributor Author

nichanghao commented Sep 1, 2025

you'd better add a unit test case to ensure this PR has fixed the issue #15410

got it

@zrlw zrlw requested review from FoghostCn, oxsean and zrlw September 1, 2025 13:37
@zrlw
Copy link
Copy Markdown
Contributor

zrlw commented Sep 1, 2025

LGTM

EarthChen
EarthChen approved these changes Sep 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zrlw
Copy link
Copy Markdown
Contributor

zrlw commented Sep 23, 2025

@oxsean do not merge until next release?

@zrlw zrlw merged commit 5c0bd7f into apache:3.3 Sep 24, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EarthChen EarthChen EarthChen approved these changes

@zrlw zrlw zrlw approved these changes

@oxsean oxsean Awaiting requested review from oxsean

@FoghostCn FoghostCn Awaiting requested review from FoghostCn

Assignees

No one assigned

Labels

type/enhancement Everything related with code enhancement or performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nichanghao @codecov-commenter @zrlw @EarthChen