[ISSUE 15635] Add support for Zookeeper-based config center and metadata reporting in Demo #15646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingyufei
force-pushed
the
feature/demo-optimization
branch
from
60a89d1 to
64e6929
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15646 +/- ##
============================================
- Coverage 61.01% 61.00% -0.02%
+ Complexity 11704 11699 -5
============================================
Files 1910 1910
Lines 86806 86806
Branches 13100 13100
============================================
- Hits 52968 52958 -10
Misses 28419 28419
- Partials 5419 5429 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zrlw
approved these changes
Aug 20, 2025
MoritzArena
pushed a commit
to MoritzArena/dubbo
that referenced
this pull request
Sep 4, 2025
…in the demo (apache#15646) Co-authored-by: Faye Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, dubbo-demo-api-consumer and dubbo-demo-api-provider doesn't have the metadata-report and config-center dependencies like dubbo-metadata-report-zookeeper.
Because of this, when testing the dubbo.application.register-mode = instance mode in dubbo-demo-api-provider, the metadata would be missing in the zookeeper. This would result in the following error when starting dubbo-demo-api-consumer.
It would be better to add dubbo-metadata-report-zookeeper and dubbo-metadata-report-zookeeper to the demo as default. This will be more convenient for debugging.
Please refer to ISSUE 15635 for more details.