Fix uninitialized non-static final fields potential NPE issue in dubbo-remoting module #15602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrlw
changed the title
zrlw
changed the title
zrlw
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15602 +/- ##
============================================
+ Coverage 61.02% 61.06% +0.03%
- Complexity 11500 11693 +193
============================================
Files 1909 1909
Lines 86782 86783 +1
Branches 13094 13094
============================================
+ Hits 52961 52995 +34
+ Misses 28409 28372 -37
- Partials 5412 5416 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
non-static final fields has initialized before construction, did I misunderstand something 
|
Member
#14848 It's different when there is multi-threading |
…ttps://github.com/zrlw/dubbo into 3.3-fixed-dubboRemoting-UninitializedFinalVariables
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes potential NullPointerException issues in the dubbo-remoting module by addressing the initialization order of non-static final fields. The changes ensure that fields are properly initialized before they can be accessed during object construction, preventing NPEs that could occur when these fields are used in constructor chains or early method calls.
- Converts final fields to non-final and moves their initialization to appropriate methods
- Restructures timer task initialization to prevent early execution before configuration is complete
- Adds proper initialization of collections and configuration values before potential usage
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| NettyServer.java (netty4) | Moves serverShutdownTimeoutMills initialization from constructor to doOpen() method |
| NettyPortUnificationServer.java (netty4) | Initializes dubboChannels and serverShutdownTimeoutMills in doOpen0() instead of constructor |
| NettyServer.java (netty) | Adds comment clarification for channels field initialization |
| NettyPortUnificationServer.java (netty) | Moves dubboChannels initialization to doOpen0() method |
| NettyHttp3Server.java | Relocates pipelineConfigurator and serverShutdownTimeoutMills initialization to doOpen() |
| MultiMessageHandler.java | Removes unnecessary @SuppressWarnings annotation |
| AbstractClient.java | Moves connectLock initialization from field declaration to constructor |
| Timer task classes | Restructures initialization to call start() after configuration instead of in parent constructor |
| AbstractPortUnificationServer.java | Moves collection initialization to doOpen() method |
| this.hashedWheelTimer = hashedWheelTimer; | ||
| this.tick = tick; | ||
| start(); | ||
| // do not start here because inheritor should set additional timeout parameters before doing task. |
There was a problem hiding this comment.
The word 'inheritor' should be 'subclass' or 'subclasses' for better clarity and standard terminology.
Suggested change
| // do not start here because inheritor should set additional timeout parameters before doing task. | |
| // do not start here because subclass should set additional timeout parameters before doing task. |
Member
|
LGTM |
RainYuY
approved these changes
Aug 1, 2025
MoritzArena
pushed a commit
to MoritzArena/dubbo
that referenced
this pull request
Sep 4, 2025
…o-remoting module (apache#15602) * Fix uninitialized final variables issue in dubbo-remoting * Remove redundant initializations of AbstractPortUnificationServer fields * Change modifier of AbstractTimerTask start method --------- Co-authored-by: earthchen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Since the non-static final fields initialized at declaration will not be initialized during it's owner object construction, NullPointerException (NPE) will be thrown if using them during the construction just like #14848
These fields should be changed to non-final and be initialized at it's owner construction to prevent NPE.
By the way, this PR only serves as a mitigation measure. The best solution is to refactor the code by:
See details at #15600
Checklist