[3.3] Add http2 server connection preface process#15535
Merged
zrlw merged 2 commits intoapache:3.3from Jul 20, 2025
Merged
Conversation
zrlw
force-pushed
the
3.3-fixed-waitClientHttp2SettingsFrame
branch
from
e3ffe76 to
01001a8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15535 +/- ##
============================================
- Coverage 60.87% 60.82% -0.06%
- Complexity 12 11433 +11421
============================================
Files 1908 1909 +1
Lines 86693 86761 +68
Branches 12997 13009 +12
============================================
- Hits 52775 52771 -4
- Misses 28462 28532 +70
- Partials 5456 5458 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zrlw
force-pushed
the
3.3-fixed-waitClientHttp2SettingsFrame
branch
13 times, most recently
from
d9bcbe3 to
6810350
Compare
zrlw
force-pushed
the
3.3-fixed-waitClientHttp2SettingsFrame
branch
3 times, most recently
from
9d23941 to
5e35cfa
Compare
…ion preface does not arrive in time
zrlw
force-pushed
the
3.3-fixed-waitClientHttp2SettingsFrame
branch
from
5e35cfa to
d1132d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
HTTP/2 server should wait for connection preface before sending first http2 data frame to client, otherwise it might also encounter the similar issue like #15460
The client posts a HTTP/1 request with
h2cupgrade contents, but the server does not wait for the http2 settings frame before sending response.Checklist