Skip to content

[3.3] Cache marked type to optimize SerializeSecurityConfigurator registerInterface performance #15500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zrlw merged 1 commit into from
Jun 30, 2025
Merged

[3.3] Cache marked type to optimize SerializeSecurityConfigurator registerInterface performance #15500

zrlw merged 1 commit into from
Jun 30, 2025

Conversation

@zrlw
Copy link
Contributor

@zrlw zrlw commented Jun 29, 2025

What is the purpose of the change?

#14937

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@zrlw zrlw mentioned this pull request Jun 29, 2025
Closed
4 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.90%. Comparing base (ea0976b) to head (c834a81).
⚠️ Report is 78 commits behind head on 3.3.

Files with missing lines Patch % Lines
...bo/common/utils/SerializeSecurityConfigurator.java 91.17% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #15500      +/-   ##
============================================
- Coverage     60.91%   60.90%   -0.02%     
+ Complexity    11469    11465       -4     
============================================
  Files          1908     1908              
  Lines         86665    86666       +1     
  Branches      12987    12988       +1     
============================================
- Hits          52796    52780      -16     
- Misses        28418    28433      +15     
- Partials       5451     5453       +2
Flag Coverage Δ
integration-tests-java17 33.00% <88.23%> (-0.01%) ⬇️
integration-tests-java8 33.06% <88.23%> (-0.05%) ⬇️
samples-tests-java17 31.42% <85.29%> (+0.01%) ⬆️
samples-tests-java8 29.30% <85.29%> (+0.09%) ⬆️
unit-tests 58.84% <91.17%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw force-pushed the 3.3-optimize-SerializeSecurityConfigurator branch from fbf01a5 to c834a81 Compare June 29, 2025 02:28
@zrlw zrlw merged commit 5bbf7ce into apache:3.3 Jun 30, 2025
29 checks passed
@zrlw zrlw deleted the 3.3-optimize-SerializeSecurityConfigurator branch June 30, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zrlw @codecov-commenter