[3.3] Await channel initialization to ensure http2 client connection preface mechanism could work properly #15460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@oxsean PTAL |
zrlw
force-pushed
the
3.3-waitBootStrapInited
branch
2 times, most recently
from
69740ee to
f0483f5
Compare
zrlw
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15460 +/- ##
============================================
+ Coverage 60.91% 60.95% +0.04%
- Complexity 11447 11452 +5
============================================
Files 1888 1888
Lines 86363 86382 +19
Branches 12956 12961 +5
============================================
+ Hits 52606 52656 +50
+ Misses 28317 28292 -25
+ Partials 5440 5434 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…seRef had been created when necessary
zrlw
force-pushed
the
3.3-waitBootStrapInited
branch
from
f0483f5 to
3c5a3ed
Compare
oxsean
requested changes
Jun 17, 2025
Contributor
oxsean
left a comment
oxsean
left a comment
There was a problem hiding this comment.
Please check the comments.
| * the countdown latch for | ||
| * {@link org.apache.dubbo.remoting.transport.netty4.NettyConnectionClient#isChannelInitialized} | ||
| */ | ||
| private CountDownLatch channelInitializedLatch; |
Contributor
There was a problem hiding this comment.
Why not use AtomicReference<Promise> to keeping the same synchronous style?
| Promise<Void> connectionPrefaceReceivedPromise = connectionPrefaceReceivedPromiseRef.get(); | ||
| if (connectionPrefaceReceivedPromise != null) { | ||
| // await channel initialization to ensure connection preface received promise had been created when necessary. | ||
| if (!isChannelInitialized) { |
Contributor
There was a problem hiding this comment.
Do we need to consider reconnection as well?
Contributor
Author
|
Current solution - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
the channel initialization is triggered by method performConnect, so performConnect should not check
connectionPrefaceReceivedPromiseRefand setconnectionPrefaceReceivedPromise, they should be created at ChannelInitializer#initChannel.Checklist