Skip to content

Conversation

@zrlw
Copy link
Contributor

@zrlw zrlw commented Jun 12, 2025

What is the purpose of the change?

try to avoid endless retrying to connect a site that might be in trouble. e.g.

--2025-06-12 01:57:17--  (try: 4)  http://apache.stu.edu.tw/zookeeper/zookeeper-3.7.2/apache-zookeeper-3.7.2-bin.tar.gz
Connecting to apache.stu.edu.tw (apache.stu.edu.tw)|120.119.118.1|:80... connected.
HTTP request sent, awaiting response... Read error (Connection timed out) in headers.
Retrying.

--2025-06-12 02:12:22--  (try: 5)  http://apache.stu.edu.tw/zookeeper/zookeeper-3.7.2/apache-zookeeper-3.7.2-bin.tar.gz
Connecting to apache.stu.edu.tw (apache.stu.edu.tw)|120.119.118.1|:80... connected.
HTTP request sent, awaiting response... Read error (Connection timed out) in headers.
Retrying.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (e849678) to head (0ec2b0e).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15452      +/-   ##
============================================
+ Coverage     60.91%   60.96%   +0.04%     
+ Complexity    11449    11444       -5     
============================================
  Files          1888     1888              
  Lines         86327    86327              
  Branches      12945    12945              
============================================
+ Hits          52586    52628      +42     
+ Misses        28308    28275      -33     
+ Partials       5433     5424       -9     
Flag Coverage Δ
integration-tests-java17 33.09% <ø> (+0.05%) ⬆️
integration-tests-java8 33.20% <ø> (+0.06%) ⬆️
samples-tests-java17 31.46% <ø> (-0.01%) ⬇️
samples-tests-java8 29.38% <ø> (+<0.01%) ⬆️
unit-tests 58.90% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw merged commit 89a7375 into apache:3.3 Jun 12, 2025
29 checks passed
@zrlw zrlw deleted the 3.3-addRetriesAndTimeoutControl4DownloadZK branch June 12, 2025 05:10
wuwen5 pushed a commit to wuwen5/dubbo that referenced this pull request Jul 23, 2025
wuwen5 added a commit to wuwen5/dubbo that referenced this pull request Jul 23, 2025
* Update zk address in workflow (apache#13177)

* Fix ci action name (apache#13337)

Signed-off-by: crazyhzm <[email protected]>

* Update zookeeper version

* Update release test

* Enhance unit test cases from scheduled tasks (apache#13099)

* Move integration test cases into apache/dubbo-integration-cases (apache#13506)

* Move integration test cases into apache/dubbo-integration-cases

* Update workflow

* Update workflow

* Update 3.3 release workflow (apache#14321)

* Update 3.3 scheduled workflow (apache#14322)

* Temporally remove sonarcloud check

* Temporally remove sonarcloud check

* Extracting unit test error logs for troubleshooting (apache#14619)

* Fix native image ci configuration (apache#14627)

* Fix zookeeper version in CI

* Fix zookeeper version in CI

* Upgrade github action version (apache#14847)

Signed-off-by: “JermaineHua” <[email protected]>

* Update Codecov Token

* Test codecov action v3

* [Bug]Fix github workflow (apache#14921)

* Replace upload artifact results (apache#15025)

* Fix CI Upload Configuration (apache#15030)

* Fix CI Upload Configuration

* Fix UnsafeByteArrayOutputStreamTest

* Add retries and timeout control to wget zookeeper file (apache#15452)

* Set debian mirror to debian archive site for getting buster packages which used by current github ubuntu-latest docker building action (apache#15541)

* Add multi-JDK testing support to PR workflow (apache#15542)

* Set unit java testing matrix to 8,11,17,21

* Update integration and samples java testing matrix from 8,17 to 8,21

---------

Co-authored-by: Rain Yu <[email protected]>
Co-authored-by: zrlw <[email protected]>

* ci:GitHub Actions

---------

Signed-off-by: crazyhzm <[email protected]>
Signed-off-by: “JermaineHua” <[email protected]>
Co-authored-by: Albumen Kevin <[email protected]>
Co-authored-by: huazhongming <[email protected]>
Co-authored-by: Sean Yang <[email protected]>
Co-authored-by: heliang666s <[email protected]>
Co-authored-by: zrlw <[email protected]>
Co-authored-by: Eric Wang <[email protected]>
Co-authored-by: Rain Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants