Skip to content

[3.3] Revert "Add connection preface process to TripleHttp2Protocol (#15368)" #15435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zrlw merged 1 commit into from
Jun 8, 2025
Merged

[3.3] Revert "Add connection preface process to TripleHttp2Protocol (#15368)" #15435

zrlw merged 1 commit into from
Jun 8, 2025

Conversation

@zrlw
Copy link
Contributor

@zrlw zrlw commented Jun 8, 2025 •
edited
Loading

This reverts commit e396bde because the revised content hasn't been reviewed yet.

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@zrlw zrlw merged commit 79683be into apache:3.3 Jun 8, 2025
1 check passed
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.90%. Comparing base (e396bde) to head (6152c53).
Report is 1 commits behind head on 3.3.

Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #15435      +/-   ##
============================================
- Coverage     60.92%   60.90%   -0.02%     
+ Complexity    11436    11421      -15     
============================================
  Files          1889     1887       -2     
  Lines         86310    86266      -44     
  Branches      12935    12929       -6     
============================================
- Hits          52583    52543      -40     
- Misses        28283    28285       +2     
+ Partials       5444     5438       -6
Flag Coverage Δ
integration-tests-java17 33.07% <ø> (+0.02%) ⬆️
integration-tests-java8 33.13% <ø> (-0.03%) ⬇️
samples-tests-java17 31.42% <ø> (-0.03%) ⬇️
samples-tests-java8 29.24% <ø> (+<0.01%) ⬆️
unit-tests 58.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw deleted the 3.3-revertConnectionPrefaceProcess branch June 9, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zrlw @codecov-commenter