Skip to content

Fix ClassCastException caused by overly broad type check in Dubbo tracing integration with Spring WebFlux. #15371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlbumenJ merged 2 commits into from
May 16, 2025
Merged

Fix ClassCastException caused by overly broad type check in Dubbo tracing integration with Spring WebFlux. #15371

AlbumenJ merged 2 commits into from
May 16, 2025

Conversation

@heliang666s
Copy link
Member

@heliang666s heliang666s commented May 12, 2025

What is the purpose of the change?

Fix ClassCastException caused by overly broad type check in Dubbo tracing integration with Spring WebFlux.
#15349

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.73%. Comparing base (d6b11cf) to head (a22851a).
Report is 78 commits behind head on 3.3.

Files with missing lines Patch % Lines
.../handler/DubboClientTracingObservationHandler.java 0.00% 1 Missing ⚠️
.../handler/DubboServerTracingObservationHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                3.3   #15371   +/-   ##
=========================================
  Coverage     60.73%   60.73%           
+ Complexity    10920    10918    -2     
=========================================
  Files          1886     1886           
  Lines         86162    86162           
  Branches      12913    12913           
=========================================
+ Hits          52328    52332    +4     
+ Misses        28374    28371    -3     
+ Partials       5460     5459    -1
Flag Coverage Δ
integration-tests 33.13% <0.00%> (+0.01%) ⬆️
samples-tests 29.35% <0.00%> (-0.01%) ⬇️
unit-tests 58.86% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

songxiaosheng
songxiaosheng approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 3515095 into apache:3.3 May 16, 2025
19 checks passed
@heliang666s heliang666s deleted the webflux branch June 22, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@songxiaosheng songxiaosheng songxiaosheng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@heliang666s @codecov-commenter @songxiaosheng @AlbumenJ