Skip to content

[3.3] Log warning message at method exceptionCaught of Netty handlers#15272

Merged
AlbumenJ merged 1 commit intoapache:3.3from
zrlw:3.3-feature-logWarnMsg4NettyException
Apr 1, 2025
Merged

[3.3] Log warning message at method exceptionCaught of Netty handlers#15272
AlbumenJ merged 1 commit intoapache:3.3from
zrlw:3.3-feature-logWarnMsg4NettyException

Conversation

@zrlw
Copy link
Copy Markdown
Contributor

@zrlw zrlw commented Mar 24, 2025 •
edited
Loading

What is the purpose of the change?

there are no exception log information when Netty server or client occurs exception, for example, NettyHandler#exceptionCaught catched server exception but does not log any exception information, only disconnected info was logged:

3.3.4-SNAPSHOT, current host: 10.1.0.250
12:21:36.654 |-INFO  [New I/O server worker #3-5] bo.remoting.transport.netty.NettyHandler:82  -|  [DUBBO] The connection between /10.1.0.250:33222 and /10.1.0.250:36882 is established, dubbo version: 3.3.4-SNAPSHOT, current host: 10.1.0.250
12:21:36.655 |-INFO  [New I/O client worker #1-2] bo.remoting.transport.netty.NettyHandler:82  -|  [DUBBO] The connection between /10.1.0.250:36882 and /10.1.0.250:33222 is established, dubbo version: 3.3.4-SNAPSHOT, current host: 10.1.0.250
.... .... <=== Netty server encountered error,  the exception was caught by NettyHandler but wasn't logged.
12:21:36.655 |-INFO  [New I/O server worker #3-5] bo.remoting.transport.netty.NettyHandler:99  -|  [DUBBO] The connection between /10.1.0.250:33222 and /10.1.0.250:36882 is disconnected, dubbo version: 3.3.4-SNAPSHOT, current host: 10.1.0.250

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.85106% with 9 lines in your changes missing coverage. Please review.

Project coverage is 60.78%. Comparing base (e2c0411) to head (29810e9).
Report is 52 commits behind head on 3.3.

Files with missing lines Patch % Lines
...e/dubbo/remoting/transport/netty/NettyHandler.java 88.00% 1 Missing and 2 partials ⚠️
.../remoting/transport/netty4/NettyClientHandler.java 70.00% 1 Missing and 2 partials ⚠️
.../remoting/transport/netty4/NettyServerHandler.java 75.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #15272      +/-   ##
============================================
+ Coverage     60.76%   60.78%   +0.01%     
- Complexity    10894    10898       +4     
============================================
  Files          1885     1885              
  Lines         86087    86112      +25     
  Branches      12896    12902       +6     
============================================
+ Hits          52314    52345      +31     
+ Misses        28323    28313      -10     
- Partials       5450     5454       +4
Flag Coverage Δ
integration-tests 33.22% <10.63%> (+0.08%) ⬆️
samples-tests 29.20% <8.51%> (-0.03%) ⬇️
unit-tests 58.91% <80.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw force-pushed the 3.3-feature-logWarnMsg4NettyException branch 2 times, most recently from 155ebb2 to c8477a8 Compare March 25, 2025 07:42
@zrlw zrlw force-pushed the 3.3-feature-logWarnMsg4NettyException branch from c8477a8 to 29810e9 Compare March 25, 2025 08:10
@AlbumenJ AlbumenJ merged commit 96556af into apache:3.3 Apr 1, 2025
19 checks passed
@zrlw zrlw deleted the 3.3-feature-logWarnMsg4NettyException branch June 5, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zrlw @codecov-commenter @AlbumenJ