remove dubbo plugin useless dependency #15236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15236 +/- ##
============================================
- Coverage 60.79% 60.78% -0.01%
+ Complexity 10892 10886 -6
============================================
Files 1885 1885
Lines 86082 86082
Branches 12895 12895
============================================
- Hits 52331 52328 -3
- Misses 28303 28309 +6
+ Partials 5448 5445 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Why remove it? is the SPI file shade check provider by this? If so, I don't think it can be removed |
Member
Author
No, I just removed dubbo-test-check. It's for integration testing. This is part of the removal of the dubbo-test module. |
4 tasks
Member
Author
|
link #15301 |
CrazyHZM
approved these changes
Apr 12, 2025
RainYuY
added a commit
to RainYuY/dubbo
that referenced
this pull request
Apr 16, 2025
…che#15236)" This reverts commit 93cfa82.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Remove dubbo-test in dubbo-plugin
Checklist