Skip to content

Ignore RejectedExecutionException if executor is shutdown during submit task #15122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlbumenJ merged 1 commit into from
Feb 13, 2025
Merged

Ignore RejectedExecutionException if executor is shutdown during submit task #15122

AlbumenJ merged 1 commit into from
Feb 13, 2025

Conversation

@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Feb 10, 2025

…it task

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@AlbumenJ AlbumenJ changed the title Ignore RejectedExecutionException if executor is shutdown during subm… Ignore RejectedExecutionException if executor is shutdown during submit task Feb 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.74%. Comparing base (22395f8) to head (480bdac).
Report is 30 commits behind head on 3.3.

Files with missing lines Patch % Lines
.../common/threadpool/serial/SerializingExecutor.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                3.3   #15122   +/-   ##
=========================================
  Coverage     60.73%   60.74%           
- Complexity    10861    10868    +7     
=========================================
  Files          1882     1883    +1     
  Lines         86007    86012    +5     
  Branches      12886    12888    +2     
=========================================
+ Hits          52236    52244    +8     
+ Misses        28326    28322    -4     
- Partials       5445     5446    +1
Flag Coverage Δ
integration-tests 33.00% <33.33%> (+<0.01%) ⬆️
samples-tests 29.20% <0.00%> (+0.02%) ⬆️
unit-tests 58.88% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ
Copy link
Member Author

AlbumenJ commented Feb 11, 2025

@EarthChen @icodening @oxsean PTAL

icodening
icodening approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@icodening icodening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit c58a699 into apache:3.3 Feb 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oxsean oxsean oxsean approved these changes

@icodening icodening icodening approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlbumenJ @codecov-commenter @oxsean @icodening