remove strong dep micrometer in tracing#14986
Merged
AlbumenJ merged 8 commits intoapache:3.3from Feb 10, 2025
Merged
Conversation
Member
|
Please fix style check |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #14986 +/- ##
============================================
- Coverage 60.75% 60.74% -0.01%
- Complexity 10864 10867 +3
============================================
Files 1882 1883 +1
Lines 86009 86009
Branches 12887 12887
============================================
- Hits 52251 52247 -4
- Misses 28313 28318 +5
+ Partials 5445 5444 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
fixed |
Member
|
Can this PR fix that issue? |
Member
Author
yes,we can lazy load micrometer class when it exists: |
AlbumenJ
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
remove strong dep micrometer in tracing
fix pr: #14872
Checklist