Skip to content

Conversation

@oxsean
Copy link
Contributor

@oxsean oxsean commented Aug 11, 2024

What is the purpose of the change

  1. Make ExceptionHandler support handling grpc exceptions
  2. Converge exception handling to onError
  3. Fix grpc not correctly close stream error when contentType is not grpc

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EarthChen PTAL

@oxsean oxsean force-pushed the refine-exception-process branch 3 times, most recently from 7a74924 to 539db0d Compare August 21, 2024 16:16
@sonarqubecloud
Copy link

@oxsean oxsean force-pushed the refine-exception-process branch 2 times, most recently from e5ef073 to 18799c6 Compare September 3, 2024 02:00
@oxsean oxsean force-pushed the refine-exception-process branch from 18799c6 to cbb885c Compare September 3, 2024 03:46
Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit d8aeba3 into apache:3.3 Sep 4, 2024
@oxsean oxsean deleted the refine-exception-process branch September 4, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants