Skip to content

WebSocket on Triple#14390

Merged
EarthChen merged 15 commits intoapache:3.3from
finefuture:3.3-websocket-support
Nov 13, 2024
Merged

WebSocket on Triple#14390
EarthChen merged 15 commits intoapache:3.3from
finefuture:3.3-websocket-support

Conversation

@finefuture
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Refer: #14298

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@finefuture finefuture force-pushed the 3.3-websocket-support branch 8 times, most recently from f55b4a2 to 67d15ef Compare July 3, 2024 09:27
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 3, 2024

@finefuture finefuture force-pushed the 3.3-websocket-support branch from 5f30fcf to 0252ed7 Compare July 8, 2024 06:44
@finefuture
Copy link
Copy Markdown
Contributor Author

Hold, this also requires adding triple client.

# Conflicts:
#	dubbo-demo/dubbo-demo-spring-boot/dubbo-demo-spring-boot-provider/src/main/resources/application.yml
#	dubbo-dependencies-bom/pom.xml
#	dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/AbstractServerHttpChannelObserver.java
#	dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 6, 2024

Comment thread dubbo-dependencies-bom/pom.xml Outdated
# Conflicts:
#	dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocol.java
#	dubbo-spring-boot/dubbo-spring-boot-3-autoconfigure/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboTriple3AutoConfiguration.java
#	dubbo-spring-boot/dubbo-spring-boot-autoconfigure/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboTripleAutoConfiguration.java
Fix issues
@finefuture finefuture requested a review from oxsean August 29, 2024 08:36
# Conflicts:
#	dubbo-distribution/dubbo-all-shaded/pom.xml
#	dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleConstants.java
#	dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http2/GenericHttp2ServerTransportListener.java
# Conflicts:
#	dubbo-spring-boot-project/dubbo-spring-boot-3-autoconfigure/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboTriple3AutoConfiguration.java
#	dubbo-spring-boot-project/dubbo-spring-boot-autoconfigure/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboTripleAutoConfiguration.java

String HTTP3_KEY = "http3";

String TRIPLE_SERVLET_KEY = "triple.servlet";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Unused.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark, it will be fixed in next pr.

Copy link
Copy Markdown
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

@Override
protected void doOnError(Throwable throwable) {}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why override empty method?

@EarthChen EarthChen merged commit 59663c8 into apache:3.3 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants