fix:Dubbo3TripleGenerator use OuterClassName error#13355
Merged
AlbumenJ merged 2 commits intoapache:3.3from Nov 14, 2023
xiaoyuuuuuupeng:3.3
Merged
fix:Dubbo3TripleGenerator use OuterClassName error#13355AlbumenJ merged 2 commits intoapache:3.3from xiaoyuuuuuupeng:3.3
AlbumenJ merged 2 commits intoapache:3.3from
xiaoyuuuuuupeng:3.3
Conversation
AlbumenJ
approved these changes
Nov 14, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #13355 +/- ##
==========================================
- Coverage 40.77% 40.76% -0.01%
==========================================
Files 1805 1805
Lines 75644 75644
Branches 10617 10617
==========================================
- Hits 30841 30839 -2
- Misses 40487 40499 +12
+ Partials 4316 4306 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








What is the purpose of the change
when
option java_outer_classnameis empty and use Dubbo3TripleGenerator generate code , the DubboxxxServiceTriple has error.My proto file :
and protoc-plugin
generated code DubboTestServiceTriple cannot find the TestServiceOuterClass

fixed: Dubbo3TripleGenerator use OuterClassName error
Brief changelog
1、change ProtoType util getJavaOuterClassname method from private to public
2、when
option java_outer_classnameis empty,serviceContext.outerClassName use ProtoType.getJavaOuterClassname method generate.Verifying this change
Checklist