fix_win11_aot_compile_NoSuchFileException,because of File.separator #12769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## 3.3 #12769 +/- ##
============================================
- Coverage 68.11% 68.08% -0.03%
Complexity 6 6
============================================
Files 1703 1703
Lines 70133 70133
Branches 10175 10175
============================================
- Hits 47768 47752 -16
- Misses 17719 17733 +14
- Partials 4646 4648 +2 see 26 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CrazyHZM
approved these changes
Jul 21, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix win11 graalvm17 dubbo aot compile throws java.nio.file.NoSuchFileException
Brief changelog
Because in Windows OS , file separator is "\" .
However in jvm/graalvm , .class file URL is always splited by "/"
So the following code does not work in Windows
org.apache.dubbo.aot.generate.JarScanner#toClassName(String path)
I change to
Checklist
[y] dubbo_issue: win11 graalvm17 dubbo aot compile throws java.nio.file.NoSuchFileException