-
Notifications
You must be signed in to change notification settings - Fork 26.6k
Closed
Labels
help wantedEverything needs help from contributorsEverything needs help from contributorstype/enhancementEverything related with code enhancement or performanceEverything related with code enhancement or performance
Description
Pre-check
- I am sure that all the content I provide is in English.
Search before asking
- I had searched in the issues and found no similar issues.
Apache Dubbo Component
Java SDK (apache/dubbo)
Dubbo Version
3.3
Steps to reproduce this issue
Configure tps on different methods of one service.
What you expected to happen
Although I can now configure tps on a method level, the stats map in DefaultTPSLimiter is still using serviceKey as the key. So the method level TPS doesn't work. Like if I configure different tps numbers on different methods, they are actually sharing the same StatItem which is obtained by service key.
I check the related issue 9159. It just fetch the tps params from method configuration, but the DefaultTPSLimiter doesn't actually support per-method-level TPS.
Anything else
No
Are you willing to submit a pull request to fix on your own?
- Yes I am willing to submit a pull request on my own!
Code of Conduct
- I agree to follow this project's Code of Conduct
Metadata
Metadata
Assignees
Labels
help wantedEverything needs help from contributorsEverything needs help from contributorstype/enhancementEverything related with code enhancement or performanceEverything related with code enhancement or performance
Type
Projects
Status
Done