fix: Avoid early cleanup of Dart workers.#19341
Merged
Merged
Conversation
In apache#19233 controllers were updated to be canceled using a combination of stop + direct thread interrupt. This patch makes worker cancellation work the same way. The change is necessary to fix a problem where the worker context could be closed before the worker finishes running, since the worker context is closed using a listener on the run future. To ensure proper sequencing, the run future must not be directly cancellable, since that would cause the listener to fire too early.
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #19233 controllers were updated to be canceled using a combination of stop + direct thread interrupt. This patch makes worker cancellation work the same way.
The change is necessary to fix a problem where the worker context could be closed before the worker finishes running, since the worker context is closed using a listener on the run future. To ensure proper sequencing, the run future must not be directly cancelable, since that would cause the listener to fire too early.