feat: add hold metrics to StorageMonitor, fix some issues with StorageLocation#19217
Merged
gianm merged 1 commit intoMar 27, 2026
Merged
Conversation
clintropolis
changed the title
clintropolis
changed the title
gianm
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes:
storage/virtual/hold/countandstorage/virtual/hold/bytestoStorageMonitorto track actively held weak cache entriesStorageLocationwhen usingfreeSpaceToKeepwhere if the second call to reclaim to obtain additional space failed,StorageLocationwould neither restore or unmount the entries, leaving behind orphans. Fixes by adjusting things so that we only call reclaim once and adjust the size based on whether we are trying to maintainfreeSpaceToKeepor notStorageLocationof reclaim leaving orphan entries if all entries needed to be evicted to satisfy the request, which would fail but not restore or unmount any entries (unlikely to occur since it would mean the reclaim request was for something that could not fit in a completely empty cache, at least until we allow mixing weak and static entries..).