MSQ: Add workerDesc to WorkerStats.#19171
Merged
Merged
Conversation
The existing field workerId is designed for MSQ itself to uniquely identify a worker. The new field workerDesc is for users (and the web console) to more easily identify where a worker is running. Its javadoc specs it as either a task ID or a host:port. This patch also updates the web console to use workerDesc, if available, to show the task (with link to the tasks view) or show the server. This replaces some older, more brittle logic that was constructing a task ID from the query ID and worker number. The approach in this patch better handles task relaunches, in which case the worker number -> task ID mapping changes.
github-actions
Bot
added
Area - Batch Ingestion
Area - Web Console
Area - MSQ
capistrant
approved these changes
Mar 18, 2026
capistrant
left a comment
capistrant
left a comment
Contributor
There was a problem hiding this comment.
I'm not a knower of typescript so I just ran locally to functionally review a dart query's tooltip of host:port. Looks to spec with what you describe!
Contributor
Author
|
I'm not a knower of typescript either 🤫 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing field workerId is designed for MSQ itself to uniquely identify a worker. The new field workerDesc is for users (and the web console) to more easily identify where a worker is running. Its javadoc specs it as either a task ID or a host:port.
This patch also updates the web console to use workerDesc, if available, to show the task (with link to the tasks view) or show the server. This replaces some older, more brittle logic that was constructing a task ID from the query ID and worker number. The approach in this patch better handles task relaunches, in which case the worker number -> task ID mapping changes.