MSQ: Save stack trace when rewriting faults.#19049
Merged
Merged
Conversation
ControllerImpl has a function mapQueryColumnNameToOutputColumnName that rewrites faults to use the user-visible column names. However, the current implementation also replaces the exceptionStackTrace. The original trace from the worker is lost, replaced by a not-very-useful one from this function on the controller. This patch changes the function so only the fault is rewritten, not the entire error report, so the original worker stack trace is preserved.
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ControllerImplhas a functionmapQueryColumnNameToOutputColumnNamethat rewrites faults to use the user-visible column names. However, the current implementation also replaces theexceptionStackTrace. The original trace from the worker is lost, replaced by a not-very-useful one from this function on the controller.This patch changes the function so only the fault is rewritten, not the entire error report, so the original worker stack trace is preserved.