Add drop reason dimension to ingest/events/thrownAway metric#18855
Merged
jtuglu1 merged 5 commits intoDec 23, 2025
Conversation
jtuglu1
force-pushed
the
ingest-dropped-event-metric-reason-dimension
branch
from
December 18, 2025 20:13
0a7d1ad to
76bbd91
Compare
jtuglu1
force-pushed
the
ingest-dropped-event-metric-reason-dimension
branch
from
December 18, 2025 20:23
76bbd91 to
36e0c72
Compare
jtuglu1
force-pushed
the
ingest-dropped-event-metric-reason-dimension
branch
3 times, most recently
from
December 19, 2025 00:28
c9c7e0d to
0ed4046
Compare
jtuglu1
marked this pull request as ready for review
December 19, 2025 02:36
kfaraz
reviewed
Dec 19, 2025
kfaraz
left a comment
Contributor
There was a problem hiding this comment.
Looks good, left some minor suggestions.
jtuglu1
force-pushed
the
ingest-dropped-event-metric-reason-dimension
branch
from
December 20, 2025 01:46
9013d02 to
5ca36a7
Compare
jtuglu1
force-pushed
the
ingest-dropped-event-metric-reason-dimension
branch
3 times, most recently
from
December 21, 2025 19:44
9d8b12a to
1704dda
Compare
jtuglu1
force-pushed
the
ingest-dropped-event-metric-reason-dimension
branch
5 times, most recently
from
December 22, 2025 07:06
3a435d8 to
c8f8981
Compare
kfaraz
reviewed
Dec 22, 2025
kfaraz
left a comment
Contributor
There was a problem hiding this comment.
Left some final suggestions.
abhishekrb19
approved these changes
Dec 22, 2025
abhishekrb19
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left a few minor comments - thanks!
jtuglu1
force-pushed
the
ingest-dropped-event-metric-reason-dimension
branch
from
December 23, 2025 02:54
78aaeae to
9a2d432
Compare
jtuglu1
force-pushed
the
ingest-dropped-event-metric-reason-dimension
branch
4 times, most recently
from
December 23, 2025 15:07
e2a2eea to
e489214
Compare
jtuglu1
force-pushed
the
ingest-dropped-event-metric-reason-dimension
branch
from
December 23, 2025 15:12
e489214 to
62440f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've found it hard to build observability on logically-dropped events (either due to transform, null, or temporal conditions).
This adds:
reasondimension to theingest/events/thrownAwaymetric for aggregating on thrown away reason.thrownAwayByReasonmap to row statistics task API response payload, so future consumers can make use of it should they need to.Release note
Add reason dimension to ingest/events/thrownAway metric. This allows for increased observability on why certain events are being logically excluded from ingest.
This PR has: