Skip to content

chore(oshi): Bump com.github.oshi:oshi-core from 6.4.4 to 6.9.1#18839

Merged
abhishekrb19 merged 1 commit into
apache:masterfrom
Rasnar:master
Dec 13, 2025
Merged

chore(oshi): Bump com.github.oshi:oshi-core from 6.4.4 to 6.9.1#18839
abhishekrb19 merged 1 commit into
apache:masterfrom
Rasnar:master

Conversation

@Rasnar

@Rasnar Rasnar commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Description

This bumps oshi to a more up to date version. The issue that we have currently is that we have the following logs in Druid:

│ 2025-12-12T09:44:30,431 WARN [MonitorScheduler-0] oshi.hardware.platform.linux.LinuxHWDiskStore - Disk Store information requires libudev, which is not present.      │

which can be disabled when you bump to 6.4.11, see: https://github.com/oshi/oshi/releases/tag/oshi-parent-6.4.11

This would allow us to disable the udev use with -Doshi.os.linux.allowudev=false.

Release note

Bump com.github.oshi:oshi-core from 6.4.4 to 6.9.1


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@abhishekrb19 abhishekrb19 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@abhishekrb19
abhishekrb19 merged commit 5247a25 into apache:master Dec 13, 2025
59 of 60 checks passed
abhishekrb19 added a commit that referenced this pull request Dec 16, 2025
Newer versions of Oshi requires a bump in JNA dependency too. Without that, running quickstart
with oshi sys monitor will fail processes with the following error:

Caused by: java.lang.NoClassDefFoundError: com/sun/jna/platform/mac/CoreFoundation$CFLocale
	at oshi.software.os.mac.MacOperatingSystem.<init>(MacOperatingSystem.java:58)
	at oshi.software.os.mac.MacOperatingSystemJNA.<init>(MacOperatingSystemJNA.java:54)
	at oshi.SystemInfo.createOperatingSystem(SystemInfo.java:87)
	at oshi.util.Memoizer$1.get(Memoizer.java:65)
	at oshi.SystemInfo.getOperatingSystem(SystemInfo.java:76)
	at org.apache.druid.java.util.metrics.OshiSysMonitor.<init>(OshiSysMonitor.java:102)
	at org.apache.druid.java.util.metrics.OshiSysMonitor.<init>(OshiSysMonitor.java:90)

Adds a unit test that fails locally with the same error without the jna dependencies bumped up.
abhishekrb19 added a commit that referenced this pull request Dec 17, 2025
* Follow up to #18839

Newer versions of Oshi requires a bump in JNA dependency too. Without that, running quickstart
with oshi sys monitor will fail processes with the following error:

Caused by: java.lang.NoClassDefFoundError: com/sun/jna/platform/mac/CoreFoundation$CFLocale
	at oshi.software.os.mac.MacOperatingSystem.<init>(MacOperatingSystem.java:58)
	at oshi.software.os.mac.MacOperatingSystemJNA.<init>(MacOperatingSystemJNA.java:54)
	at oshi.SystemInfo.createOperatingSystem(SystemInfo.java:87)
	at oshi.util.Memoizer$1.get(Memoizer.java:65)
	at oshi.SystemInfo.getOperatingSystem(SystemInfo.java:76)
	at org.apache.druid.java.util.metrics.OshiSysMonitor.<init>(OshiSysMonitor.java:102)
	at org.apache.druid.java.util.metrics.OshiSysMonitor.<init>(OshiSysMonitor.java:90)

Adds a unit test that fails locally with the same error without the jna dependencies bumped up.
@kgyrtkirk kgyrtkirk added this to the 36.0.0 milestone Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants