MSQ: Set includeAllCounters to true by default.#18761
Merged
Merged
Conversation
This is a backwards-compatibility option needed for rolling updates from Druid 30 and earlier. Flipping it to true means that the out-of-box experience will include new counters that have been added since then, such as CPU usage counters.
github-actions
Bot
added
Area - Documentation
Area - Batch Ingestion
Area - MSQ
clintropolis
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backwards-compatibility option needed for rolling updates from Druid 30 and earlier. Flipping it to true means that the out-of-box experience will include new counters that have been added since then, such as CPU usage counters.
Release note:
When upgrading from Druid 30 or earlier, MSQ
query_controllertasks can fail during a rolling update due to the addition of new counters that are not backwards compatible with these older versions. You can either retry any failed queries after the update completes; or you can setincludeAllCounterstofalsein the query context for any MSQ jobs that need to run during the rolling update; or you can upgrade to Druid 31–35 first before upgrading to Druid 36.